fix: enable decimal input in Number field#68
Merged
nicolas-jaussaud merged 2 commits intomainfrom Mar 16, 2026
Merged
Conversation
The Number component was rejecting decimal input due to two issues: 1. No `formatOptions` passed to react-aria's `useNumberFieldState` and `useNumberField`, so the NumberParser rejected decimal characters during input validation. 2. The `<input>` value was overridden with `Number.isInteger(state.numberValue) ? state.numberValue : 0`, which collapsed any non-integer to 0 — preventing the user from ever typing a decimal point. Fix: pass memoized `formatOptions` with `maximumFractionDigits: 10` to both hooks (must be memoized — react-stately uses reference equality), remove the value override so react-aria controls the input natively, and expose a `step` prop (default 1) for +/- button increment granularity. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
Author
Validate the decimal input fix with tests covering initial decimal values (float and string), user-typed decimals, step increment behavior via button clicks, and formatOptions truncation. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
|
^-^ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Number component was rejecting decimal input due to two issues:
No
formatOptionspassed to react-aria'suseNumberFieldStateanduseNumberField, so the NumberParser rejected decimal characters during input validation.The
<input>value was overridden withNumber.isInteger(state.numberValue) ? state.numberValue : 0, which collapsed any non-integer to 0 — preventing the user from ever typing a decimal point.Fix: pass memoized
formatOptionswithmaximumFractionDigits: 10to both hooks (must be memoized — react-stately uses reference equality), remove the value override so react-aria controls the input natively, and expose astepprop (default 1) for +/- button increment granularity.